[SCHEMA] Allow acq-* to relate physio data to MRI data in anat/ as described in #2164#1990
Closed
tstoeter wants to merge 2 commits intobids-standard:masterfrom
Closed
[SCHEMA] Allow acq-* to relate physio data to MRI data in anat/ as described in #2164#1990tstoeter wants to merge 2 commits intobids-standard:masterfrom
acq-* to relate physio data to MRI data in anat/ as described in #2164#1990tstoeter wants to merge 2 commits intobids-standard:masterfrom
Conversation
…ed in bids-standard#2164 The deno based validator did not accept files like `sub-01_acq-T1w_physio.tsv.gz` located in `anat/` and related to the T1w anatomy. This was, because a task was required, which was inherited from `rules.files.raw.task.timeseries.entities`. The key task is now overridden to optional. Please also see issue bids-standard#2164 for more information and related patches.
Member
|
I think |
Contributor
Author
|
Thank you, @tsalo, for your suggestion, indeed from reading the specs I believe, this requires another modification of the schema to fix it. |
Collaborator
|
The task entity is already inherited via bids-specification/src/schema/rules/files/raw/task.yaml Lines 108 to 109 in c81144b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deno based validator did not accept files like
sub-01_acq-T1w_physio.tsv.gzlocated inanat/and related to the T1w anatomy. This was, because a task was required, which was inherited fromrules.files.raw.task.timeseries.entities. The key task is now overridden to optional. Please also see issue #2164 for more information and related patches.