[SCHEMA] Configure only the bst logger instead of the root logger#1996
Merged
effigies merged 4 commits intobids-standard:masterfrom Dec 5, 2024
Merged
[SCHEMA] Configure only the bst logger instead of the root logger#1996effigies merged 4 commits intobids-standard:masterfrom
effigies merged 4 commits intobids-standard:masterfrom
Conversation
for more information, see https://pre-commit.ci
effigies
approved these changes
Dec 5, 2024
Remi-Gau
approved these changes
Dec 5, 2024
effigies
pushed a commit
that referenced
this pull request
Dec 5, 2024
) * Configure only the bst logger instead of the root logger * Add a logging handler if there are none * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix flake8
effigies
added
schema-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in which third-party projects using the
bidsschematoolspython package might have logging issues.Currently, the
bidsschematoolspackage is reconfiguring the python root logger in order to set the format, which also adds a handler to the root logger. This affects pybids, which also affects templateflow and, in consecuence, any other tool using templateflow.This PR should not create any imcompatibility as it is just a logging reconfiguration and does not modify the schema nor the logic of the code handling the schema.