Skip to content

[FIX] update some internal links #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
effigies merged 10 commits into from
Dec 12, 2024
Merged

[FIX] update some internal links #2004

effigies merged 10 commits into from
Dec 12, 2024

Conversation

@Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Dec 12, 2024

@Remi-Gau Remi-Gau added the exclude-from-changelog This item will not feature in the automatically generated changelog label Dec 12, 2024
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 12, 2024

silly auto reformat gives you a huge diff... grrr

effigies
effigies reviewed Dec 12, 2024
View reviewed changes
effigies
effigies reviewed Dec 12, 2024
View reviewed changes
Remi-Gau
Remi-Gau commented Dec 12, 2024
View reviewed changes
effigies
effigies approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge if you're ready.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 12, 2024

most errors left are related to subobects rendering: won't fix here

https://app.readthedocs.org/projects/bids-specification/builds/26570977/#253898759--15

INFO    -  Doc file 'modality-agnostic-files.md' contains a link './glossary.md#objects.subobject.Name', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Name'.
INFO    -  Doc file 'modality-agnostic-files.md' contains a link './glossary.md#objects.subobject.Version', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Version'.
INFO    -  Doc file 'modality-agnostic-files.md' contains a link './glossary.md#objects.subobject.Description', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Description'.
INFO    -  Doc file 'modality-agnostic-files.md' contains a link './glossary.md#objects.subobject.CodeURL', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodeURL'.
INFO    -  Doc file 'modality-agnostic-files.md' contains a link './glossary.md#objects.subobject.Container', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Container'.
INFO    -  Doc file 'appendices/entity-table.md' contains a link '../glossary.md#objects.suffixes.PLI', but the doc 'glossary.md' does not contain an anchor '#objects.suffixes.PLI'.
INFO    -  Doc file 'appendices/entity-table.md' contains a link '../glossary.md#objects.suffixes.2PE', but the doc 'glossary.md' does not contain an anchor '#objects.suffixes.2PE'.
INFO    -  Doc file 'modality-specific-files/genetic-descriptor.md' contains a link '../glossary.md#objects.subobject.Dataset', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Dataset'.
INFO    -  Doc file 'modality-specific-files/genetic-descriptor.md' contains a link '../glossary.md#objects.subobject.Database', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Database'.
INFO    -  Doc file 'modality-specific-files/genetic-descriptor.md' contains a link '../glossary.md#objects.subobject.Descriptors', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Descriptors'.
INFO    -  Doc file 'modality-specific-files/magnetic-resonance-imaging-data.md' contains a link '#in-and-out-plane-spatial-encoding', but there is no such anchor on this page.
INFO    -  Doc file 'modality-specific-files/magnetic-resonance-imaging-data.md' contains a link '../glossary.md#objects.subobject.CodeValue', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodeValue'.
INFO    -  Doc file 'modality-specific-files/magnetic-resonance-imaging-data.md' contains a link '../glossary.md#objects.subobject.CodeMeaning', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodeMeaning'.
INFO    -  Doc file 'modality-specific-files/magnetic-resonance-imaging-data.md' contains a link '../glossary.md#objects.subobject.CodingSchemeDesignator', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodingSchemeDesignator'.
INFO    -  Doc file 'modality-specific-files/magnetic-resonance-imaging-data.md' contains a link '../glossary.md#objects.subobject.CodingSchemeVersion', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodingSchemeVersion'.
INFO    -  Doc file 'modality-specific-files/microscopy.md' contains a link '../glossary.md#objects.suffixes.PLI', but the doc 'glossary.md' does not contain an anchor '#objects.suffixes.PLI'.
INFO    -  Doc file 'modality-specific-files/positron-emission-tomography.md' contains a link '../glossary.md#objects.subobject.CodeValue', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodeValue'.
INFO    -  Doc file 'modality-specific-files/positron-emission-tomography.md' contains a link '../glossary.md#objects.subobject.CodeMeaning', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodeMeaning'.
INFO    -  Doc file 'modality-specific-files/positron-emission-tomography.md' contains a link '../glossary.md#objects.subobject.CodingSchemeDesignator', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodingSchemeDesignator'.
INFO    -  Doc file 'modality-specific-files/positron-emission-tomography.md' contains a link '../glossary.md#objects.subobject.CodingSchemeVersion', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.CodingSchemeVersion'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.OperatingSystem', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.OperatingSystem'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.ScreenDistance', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.ScreenDistance'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.ScreenRefreshRate', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.ScreenRefreshRate'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.ScreenResolution', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.ScreenResolution'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.ScreenSize', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.ScreenSize'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.SoftwareName', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.SoftwareName'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.SoftwareRRID', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.SoftwareRRID'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.SoftwareVersion', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.SoftwareVersion'.
INFO    -  Doc file 'modality-specific-files/task-events.md' contains a link '../glossary.md#objects.subobject.Code', but the doc 'glossary.md' does not contain an anchor '#objects.subobject.Code'.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 12, 2024

had missed one

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 12, 2024

still not sure about PLE and PI suffixes error but that will be for another day

@effigies
Copy link
Collaborator

effigies commented Dec 12, 2024

INFO - Doc file 'appendices/entity-table.md' contains a link '../glossary.md#objects.suffixes.PLI', but the doc 'glossary.md' does not contain an anchor '#objects.suffixes.PLI'.
INFO - Doc file 'appendices/entity-table.md' contains a link '../glossary.md#objects.suffixes.2PE', but the doc 'glossary.md' does
INFO - Doc file 'modality-specific-files/microscopy.md' contains a link '../glossary.md#objects.suffixes.PLI', but the doc 'glossary.md' does not contain an anchor '#objects.suffixes.PLI'.

These are all fixable. #pli-suffix and #twope-suffix.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Dec 12, 2024

These are all fixable. #pli-suffix and #twope-suffix.

but I think they are generated by macros, no?

@effigies effigies merged commit 00917e6 into bids-standard:master Dec 12, 2024
24 of 25 checks passed
@Remi-Gau Remi-Gau deleted the fix/2003 branch December 13, 2024 07:19
@Remi-Gau Remi-Gau mentioned this pull request Dec 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effigies effigies effigies approved these changes

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

@sappelhoff sappelhoff Awaiting requested review from sappelhoff sappelhoff is a code owner

@ezemikulan ezemikulan Awaiting requested review from ezemikulan ezemikulan is a code owner

Assignees

No one assigned

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] broken internal links

2 participants

@Remi-Gau @effigies