[ENH] Define "phenotype" as a data type not nested inside subjects #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
attn @bids-standard/bep036 |
ericearl
reviewed
Feb 13, 2025
| 15. `phenotype` (participant-level measurement and survey data) | ||
|
|
||
| For files that are subject- and session- specific, the data type directory | ||
| is nested inside those directories. |
There was a problem hiding this comment.
Does this mean phenotype/ is permitted, but not required under the subject/[session/] directory? BEP036 is leaning into the aggregated model of tabular phenotypic data file storage at the root-level phenotype/ subdirectory.
There was a problem hiding this comment.
To permit it, we would need a file rule where subject and session are optional, so this describes the current situation reasonably well, as it can't be subject- or session- specific.
I do not have a specific objection to permitting it to be used inside subject/session directories, but if BEP036 is not proposing it, it won't happen.
Happy to consider alternative wordings that make this clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1828. Please continue the conversation in that issue, and reserve this PR for discussing concrete changes.