Skip to content

Conversation

@musicinmybrain
Copy link
Contributor

Before:

bids-specification/tools/schemacode $ python3 -m build
bids-specification/tools/schemacode $ tar -tzvf dist/*.gz | grep git
-rw-r--r-- 0/0               2 2025-05-16 10:53 bidsschematools-1.1.0.dev0/.gitignore
-rw-r--r-- 0/0              15 2025-05-16 10:44 bidsschematools-1.1.0.dev0/tests/data/.gitignore

After:

bids-specification/tools/schemacode $ git clean -fxd
bids-specification/tools/schemacode $ python3 -m build
bids-specification/tools/schemacode $ tar -tzvf dist/*.gz | grep git
(no output)

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (1e14c26) to head (b4faef2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2117   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files          17       17           
  Lines        1531     1531           
=======================================
  Hits         1257     1257           
  Misses        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies
Copy link
Collaborator

Would you mind targeting maint/1.10.0?

@musicinmybrain musicinmybrain changed the base branch from master to maint/1.10.0 May 16, 2025 16:13
@musicinmybrain
Copy link
Contributor Author

musicinmybrain commented May 16, 2025

Would you mind targeting maint/1.10.0?

Done! Unfortunately, the intermediate state while I was retargeting this PR caused GitHub to ping a lot of people unnecessarily.

@effigies
Copy link
Collaborator

Weirdly, this doesn't seem to fix things in CI (https://github.com/bids-standard/bids-specification/actions/runs/15069847259/job/42363116831), and I don't have the problem locally. I'm going to try pushing a more up-to-date build process...

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@effigies effigies merged commit 19c7afe into bids-standard:maint/1.10.0 May 16, 2025
17 of 18 checks passed
@musicinmybrain
Copy link
Contributor Author

musicinmybrain commented May 16, 2025

I confirm that 1.0.8 looks right to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants