-
Notifications
You must be signed in to change notification settings - Fork 190
[MISC] In bidsschematools, exclude .gitignore files from sdists #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] In bidsschematools, exclude .gitignore files from sdists #2117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2117 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 17 17
Lines 1531 1531
=======================================
Hits 1257 1257
Misses 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would you mind targeting |
Done! Unfortunately, the intermediate state while I was retargeting this PR caused GitHub to ping a lot of people unnecessarily. |
|
Weirdly, this doesn't seem to fix things in CI (https://github.com/bids-standard/bids-specification/actions/runs/15069847259/job/42363116831), and I don't have the problem locally. I'm going to try pushing a more up-to-date build process... |
effigies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I confirm that 1.0.8 looks right to me. Thanks. |
Before:
After: