Skip to content

Conversation

@VisLab
Copy link
Member

@VisLab VisLab commented Jun 2, 2025

HED used to be allowed in various .tsv files including the participants.tsv, scans.tsv, sessions.tsv, and samples.tsv as well as the .tsv files in the phenotypes directory. At some point this became disallowed, and the HED in these files may not be validated. The eeg_ds003645s_hed_demo dataset in the bids examples illustrates this usage.

This PR modifies the schema to allow them again. It does not address the phenotypes directory, as I am not sure how this should be done.

@VisLab VisLab requested a review from erdalkaraca as a code owner June 2, 2025 21:49
@VisLab VisLab requested review from effigies, sappelhoff and tsalo and removed request for erdalkaraca June 2, 2025 21:50
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.06%. Comparing base (678e02b) to head (de688e2).
⚠️ Report is 228 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2125   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files          17       17           
  Lines        1533     1533           
=======================================
  Hits         1258     1258           
  Misses        275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this was disallowed so much as an oversight in schema development, that turned into dropped support when we switched from the legacy validator.

I think this patch could probably be made against the maint/1.10.0 branch as a fixup to the schema.

@effigies
Copy link
Collaborator

effigies commented Jun 3, 2025

And it looks like we're not validating phenotype files at all. That should be patched, as well...

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Jun 3, 2025
@effigies
Copy link
Collaborator

effigies commented Jun 3, 2025

Done in #2126 and merged into master in 8e77449.

@effigies effigies closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants