Skip to content

feat(schema): Add meta.templates and allow for composing multiple references #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Collaborator

This is pulled out of #1714, which needs a way of constructing file rules by composing raw rules with rules adapted for atlas datasets. Since atlas datasets are just derivatives datasets, we can do much of the work in advance.

@effigies effigies added schema-code Updates or changes to the code used to parse, filter, and render the schema. exclude-from-changelog This item will not feature in the automatically generated changelog labels Jun 18, 2025
@effigies effigies force-pushed the multiref branch 4 times, most recently from 2fcb4b9 to 723c265 Compare June 20, 2025 12:10
@effigies effigies marked this pull request as ready for review June 20, 2025 12:10
@effigies effigies requested a review from erdalkaraca as a code owner June 20, 2025 12:10
@effigies effigies requested review from oesteban and rwblair June 20, 2025 12:10
@effigies
Copy link
Collaborator Author

@oesteban Pinging you because this is adapted from your work in BEP38. I'll also make a PR against BEP38 with the relevant changes.

Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.85%. Comparing base (04faf74) to head (2e78f75).

Files with missing lines Patch % Lines
tools/schemacode/src/bidsschematools/schema.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
+ Coverage   82.71%   82.85%   +0.13%     
==========================================
  Files          20       20              
  Lines        1608     1621      +13     
==========================================
+ Hits         1330     1343      +13     
  Misses        278      278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant