Update BEP-023 from master #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries and subjects listed in phenotype files (#2044) * Update src/schema/objects/files.yaml The participants schema description now contains the comprehensive superset rule from #914. * Update src/schema/objects/files.yaml Committing the good suggestion. Co-authored-by: Chris Markiewicz <[email protected]> * Update src/schema/objects/files.yaml * doc(schema): Update intersects() to return the intersection if non-empty * feat(schema): Require participants.tsv to be a superset of sub_dirs/participants * schema: Improve error messages --------- Co-authored-by: Chris Markiewicz <[email protected]> Co-authored-by: Chris Markiewicz <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
updates: - [github.com/pyCQA/flake8: 7.1.1 → 7.1.2](PyCQA/flake8@7.1.1...7.1.2)
[pre-commit.ci] pre-commit autoupdate
chore(schematools): Add configuration for bump-my-version
fix: Use of min/maxItems in types of ScreenSize/ScreenResolution
I found not a single openneuro datasets with negative onsets.
smaug:/mnt/datasets/datalad/crawl/openneuro
*$> for ds in ds*; do git grep '^ *-' '**_events.tsv' | head ; done
But ATM we are looking at a dataset with some buggy _events.tsv which has huge
negative values sorted within onsets column. I think in general/theory in some
.1% of the cases there could be point to have onsets with negative onsets, e.g.
due to desire to encode some preparatory to the data scanning activities (e.g.
during dummy scans etc). So for those -- it would be nice to have a dedicated
ERROR code to ignore/overwrite. But in general, it just signals a problem with
the file and thus IMHO should be an ERROR.
As @tsalo pointed out in #2075 (comment) there is a test in expression_tests.yaml which ensures that -1 is less than n/a Fix comparison to be >= -- it is a check to pass. Make it a warning and only on implausible negative (over 60 sec before) events Co-authored-by: Chris Markiewicz <[email protected]>
=== Do not change lines below ===
{
"chain": [],
"cmd": "git-sedi Implausible Suspicious; git-sedi IMPLAUSIBLE SUSPICIOUS",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
The DICOM tag (0018,9081) is a boolean value, not a partial Fourier fraction. Closes gh-2110.
[ENH] Clarify that electrodes.tsv are REQUIRED for iEEG data
…2129) * fix: schemapath resolution in Windows dev mode installation of bidsschematools * chore: add to contributors * chore: shorten line for ruff * refactor: recommended nesting
Event onsets SHOULD NOT be negative or extremely large
Defaced derivative example should be in a pipeline subdirectory
* enh: Accept UTC offsets in datetimes * test: Fix expected datetime patterns
…/` (#1991) * [SCHEMA] Allow `mod-*` to relate physio data to MRI data in `anat/` `mod` seems to be more appropriate, but was also not yet supported. * Update task.yaml --------- Co-authored-by: Chris Markiewicz <[email protected]>
…ading Inheritance Principle: Advise against value overloading. Plan to deprecate support for overloading for BIDS 2.0
[FIX] Re-align the text and the schema for filenames in derivatives
[FIX] Remove incorrect DICOM correspondence of PartialFourier
FIX: Rescope or downgrade excess RECOMMENDED fields
[INFRA] Use uv to manage the build environment
mnoergaard
requested review from
DimitriPapadopoulos,
effigies,
erdalkaraca,
ezemikulan,
sappelhoff and
tsalo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.