[BEP032] [FIX] Validation rules for events #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Jul 3, 2025
| entities: | ||
| subject: required | ||
| session: optional | ||
| task: optional |
Collaborator
There was a problem hiding this comment.
is that what we want? (have task optional)
I think we better
- align with what most of other modalities mandate for entities
- do not add this section here, but rather add our two
datatypesto the top record in this file oneventswhich already covers most of other datatypes
Contributor
Author
There was a problem hiding this comment.
is that what we want? (have task optional)
Yes, decided in meeting earlier. There might not always be a prescribed 'task' that can be labeled, nor multiple tasks to be distinguished
do not add this section here, but rather add our two datatypes to the top record in this file on events which already covers most of other datatypes
That is how the PR started but then the other location was discovered, and that seems to be where all the other subspecialty types are grouped so we decided to follow established convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolved some issues with my events file validation (under an ecephys directory following BEP032)
Included the other new suffixes for good measure
However, I get the following invalidation remaining on https://dandiarchive.org/dandiset/001470/draft/files?location=sub-M541/ses-M54120240831/ecephys
[ERROR] REQUIRED_COORDSYSTEM If an electrodes.tsv file is provided, an associated coordsystem.json must also be present. /sub-M541/ses-M54120240831/ecephys/sub-M541_ses-M54120240831_electrodes.tsv - rules.checks.channels.RequiredCoordsystem Please visit https://neurostars.org/search?q=REQUIRED_COORDSYSTEM for existing conversations about this issue. [ERROR] SIDECAR_WITHOUT_DATAFILE A json sidecar file was found without a corresponding data file /sub-M541/ses-M54120240831/ecephys/sub-M541_ses-M54120240831_coordsystem.jsonwhich as you can see, has a
coordsystem.jsonpresent (granted it's empty - still working on how the content should actually appear... but that wouldn't matter, right? Or at least give a different error like 'coordsystem content is empty'?)Any ideas on resolving that issue @effigies?