Skip to content

Conversation

@bendichter
Copy link
Contributor

@bendichter bendichter commented Aug 3, 2025

  • Replace x,y,z coordinates with standardized AP/ML/DV system
  • Add anatomical reference points (Bregma/Lambda) explanations
  • Include detailed angle measurement conventions with diagrams
  • Add 6 illustrative images for coordinate system understanding
  • Update electrode table example to use new coordinate naming

Consistent with BrainSTEM and AINDS

…ides

- Replace x,y,z coordinates with standardized AP/ML/DV system
- Add anatomical reference points (Bregma/Lambda) explanations
- Include detailed angle measurement conventions with diagrams
- Add 6 illustrative images for coordinate system understanding
- Update electrode table example to use new coordinate naming
- Add AP__probes column for Anterior-Posterior probe positioning
- Add ML__probes column for Medial-Lateral probe positioning
- Add missing unit specification (mm) to existing DV__probes column
@bendichter bendichter marked this pull request as ready for review August 3, 2025 21:41
@bendichter bendichter requested a review from erdalkaraca as a code owner August 3, 2025 21:41
@bendichter
Copy link
Contributor Author

bendichter commented Aug 3, 2025

@apdavison, @lzehl, @ree-gupta

@bendichter
Copy link
Contributor Author

@CodyCBakerPhD

Copy link
Contributor

@CodyCBakerPhD CodyCBakerPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bendichter bendichter merged commit 18ad16b into bep032 Aug 4, 2025
15 of 18 checks passed
@effigies effigies deleted the bep32_rotation branch August 4, 2025 18:07
Copy link
Member

@ree-gupta ree-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben for working on this! :)

The rules.tabular_data.microphys needs to be updated too to reflect these changes in rendered table of column headers.


```tsv
electrode_id probe_id impedance x y z material location
electrode_id probe_id impedance AP ML DV material location
Copy link
Member

@ree-gupta ree-gupta Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the AP, ML, DV be present in probes.tsv instead? The x, y and z for electrodes would still remain as x, y and z (for 3D), described relative to the probe origin, right? And maybe optional here if a probeinterface.json file is provided?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think I accidentaly changed the wrong table. I meant to have AP ML DV on the probes tsv, not electrodes (for backwards compatibility)

name: roll
display_name: Roll rotation
AP_angle:
name: AP_angle
Copy link
Member

@ree-gupta ree-gupta Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to contribution guidelines, the headers must be snake_case. I see an exception with HED, do we think of an alternate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants