-
Notifications
You must be signed in to change notification settings - Fork 190
Add comprehensive stereotaxic coordinate documentation with visual guides #2160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ides - Replace x,y,z coordinates with standardized AP/ML/DV system - Add anatomical reference points (Bregma/Lambda) explanations - Include detailed angle measurement conventions with diagrams - Add 6 illustrative images for coordinate system understanding - Update electrode table example to use new coordinate naming
- Add AP__probes column for Anterior-Posterior probe positioning - Add ML__probes column for Medial-Lateral probe positioning - Add missing unit specification (mm) to existing DV__probes column
…s-specification into bep32_rotation
CodyCBakerPhD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ree-gupta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben for working on this! :)
The rules.tabular_data.microphys needs to be updated too to reflect these changes in rendered table of column headers.
|
|
||
| ```tsv | ||
| electrode_id probe_id impedance x y z material location | ||
| electrode_id probe_id impedance AP ML DV material location |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the AP, ML, DV be present in probes.tsv instead? The x, y and z for electrodes would still remain as x, y and z (for 3D), described relative to the probe origin, right? And maybe optional here if a probeinterface.json file is provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think I accidentaly changed the wrong table. I meant to have AP ML DV on the probes tsv, not electrodes (for backwards compatibility)
| name: roll | ||
| display_name: Roll rotation | ||
| AP_angle: | ||
| name: AP_angle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to contribution guidelines, the headers must be snake_case. I see an exception with HED, do we think of an alternate?
Consistent with BrainSTEM and AINDS