Skip to content

Conversation

@effigies
Copy link
Collaborator

@effigies effigies commented Sep 4, 2025

This got caught up in the mass update from #1964. It broke Zenodo because they can't take a joke.

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (8fd451a) to head (31c0a14).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2199   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          20       20           
  Lines        1608     1608           
=======================================
  Hits         1330     1330           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies effigies merged commit a64e100 into bids-standard:master Sep 4, 2025
24 of 25 checks passed
@yarikoptic
Copy link
Collaborator

and here is how it looks the exception which was provided

❯ git co a64e100665b57ce147d8fc40bfa72eeef9bd2a2d^
Note: switching to 'a64e100665b57ce147d8fc40bfa72eeef9bd2a2d^'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8fd451a90 Merge pull request #2190 from bids-standard/dependabot/github_actions/actions-infrastructure-7921bc0373

❯ uv run /tmp/validate_citation.py
Installed 78 packages in 81ms
Traceback (most recent call last):
  File "/tmp/validate_citation.py", line 38, in <module>
    main()
    ~~~~^^
  File "/tmp/validate_citation.py", line 32, in main
    legacy_data = {"metadata": CitationMetadataSchema().load(data)}
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/home/yoh/.cache/uv/environments-v2/validate-citation-b9e60e9f6ca123ac/lib/python3.13/site-packages/marshmallow/schema.py", line 792, in load
    return self._do_load(
           ~~~~~~~~~~~~~^
        data, many=many, partial=partial, unknown=unknown, postprocess=True
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/yoh/.cache/uv/environments-v2/validate-citation-b9e60e9f6ca123ac/lib/python3.13/site-packages/marshmallow/schema.py", line 999, in _do_load
    raise exc
marshmallow.exceptions.ValidationError: {'authors': {233: {'orcid': ['Invalid orcid provided : https://orcid.org/0320-4024-4203-5343']}}}

so just about an invalid ORCID!

@effigies effigies deleted the fix/marie-curie branch September 4, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants