Skip to content

Conversation

@effigies
Copy link
Collaborator

@effigies effigies commented Sep 5, 2025

As of #1440, events files are no longer assumed to be associated with task data files (although currently all events files do have a required task entity). This brings meta.associations.events into line, so that events files can be found.

This is somewhat abstract and will come at a slight cost to the validator, but other tools using meta.associations to find associated files will benefit from removing the restriction.

@effigies effigies requested review from VisLab and rwblair September 5, 2025 15:44
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Sep 5, 2025
@effigies effigies added this to the 1.10.1 milestone Sep 5, 2025
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (2ca8e81) to head (6baefcb).
⚠️ Report is 18 commits behind head on maint/1.10.1.

Additional details and impacted files
@@              Coverage Diff              @@
##           maint/1.10.1    #2202   +/-   ##
=============================================
  Coverage         82.71%   82.71%           
=============================================
  Files                20       20           
  Lines              1608     1608           
=============================================
  Hits               1330     1330           
  Misses              278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies effigies added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Sep 5, 2025
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that task should be removed as a required entity for events from a number of the modality specifications, but this is a task for the future.

@effigies effigies merged commit 7226486 into bids-standard:maint/1.10.1 Sep 6, 2025
21 checks passed
@effigies effigies deleted the fix/relax-events-filter branch September 6, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants