-
Notifications
You must be signed in to change notification settings - Fork 190
[ENH] Add entity tables for motion, NIRS and MRS #2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2209 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 20 20
Lines 1608 1608
=======================================
Hits 1330 1330
Misses 278 278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for catching this! Could you add nirs and mrs as well? |
effigies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@effigies, very quick approval. After checking the render, I also allowed |
|
My impression was that |
|
Sorry, that is true. I just revisited the definition of recording "[This entity is commonly applied when continuous recordings are from different acquisition instruments, or have different sampling frequencies or start times.]". I will remove it again. |
… is very similar to `tracksys`
tsalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the rendered docs and it looks good to me.
[ENH] Add entity tables for motion, NIRS and MRS
Given that motion data is currently the only entity which uses the
tracksyslabel, it would be nice to showcase this in the enitiy tables.