Skip to content

Conversation

@JuliusWelzel
Copy link
Collaborator

@JuliusWelzel JuliusWelzel commented Sep 9, 2025

Given that motion data is currently the only entity which uses the tracksys label, it would be nice to showcase this in the enitiy tables.

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (ff9f43f) to head (5f0a0c3).
⚠️ Report is 80 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2209   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          20       20           
  Lines        1608     1608           
=======================================
  Hits         1330     1330           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies
Copy link
Collaborator

effigies commented Sep 9, 2025

Thanks for catching this! Could you add nirs and mrs as well?

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@effigies effigies changed the title [ENH] Add motion entity table [ENH] Add entity tables for motion, NIRS and MRS Sep 9, 2025
@JuliusWelzel
Copy link
Collaborator Author

@effigies, very quick approval. After checking the render, I also allowed recording to be used for motion data.

@effigies
Copy link
Collaborator

effigies commented Sep 9, 2025

My impression was that tracksys served the same purposes as recording in motion?

@JuliusWelzel
Copy link
Collaborator Author

Sorry, that is true. I just revisited the definition of recording "[This entity is commonly applied when continuous recordings are from different acquisition instruments, or have different sampling frequencies or start times.]". I will remove it again.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the rendered docs and it looks good to me.

@effigies effigies merged commit 73281ae into bids-standard:master Sep 9, 2025
27 checks passed
@JuliusWelzel
Copy link
Collaborator Author

Thanks @effigies and @tsalo for the quick review!

drammock pushed a commit to drammock/bids-specification that referenced this pull request Sep 22, 2025
[ENH] Add entity tables for motion, NIRS and MRS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants