-
Notifications
You must be signed in to change notification settings - Fork 190
[INFRA] Use full page width #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2216 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 20 20
Lines 1608 1608
=======================================
Hits 1330 1330
Misses 278 278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@thinknoack @nellh I'd be interested in your takes on this. |
this makes sense and utilizes the available space. 👍 alternatives (if you want to try and see if they work for you?) for the table
If you want to see in action. I was able to get something working here > https://bids-specification.readthedocs.io/en/latest/derivatives/common-data-types.html you'll want to add this to see: screenshots of above css for table for the code (
|
julia-pfarr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
nellh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good change.



In many cases, our content is naturally wider than our theme (mkdocs-material) handles comfortably. Filename templates and metadata tables are frequently a bit squashed feeling.
This PR sets the max-width of the content pane to
fit-contentinstead of61rem. I believe this will always be the same as using the full screen width, but at least allows the possibility that a page with narrow contents would be better centered.Relates somewhat to #1784, which addressed the impact of the narrow content frame on the entity tables.
References:
Before
After