fix: Use max of float-or-array fields for numerical metadata checks

[tsalo]

Closes #2234.

Changes proposed:

• Instead of directly comparing fields that can either be floats or arrays to a single value, take the max of the field. This assumes that max(float) will return the float. The checks I modified are PostLabelingDelayGreater, BolusCutOffDelayTimeGreater, LabelingDurationGreater, and EchoTimeGreaterThan.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (d62a5d2) to head (d76c8b9).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          20       20           
  Lines        1608     1608           
=======================================
  Hits         1330     1330           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[effigies]

I agree. Can you base this on maint/1.10.1 so that we can cut a patched schema release?

[tsalo]

I'm happy to add explicit tests for max(float). I think the right place is schema/meta/expression_tests.yaml, but please correct me if I'm wrong.

[effigies]

Searching through objects.metadata for anyOf:\n.*type: number:

• BolusCutoffDelayTime
• EchoTime
• FlipAngle
• FrequencyOffset
• HeadCoilFrequency
• LabelingDuration
• NumberShots
• PharmaceuticalDoseAmount
• PharmaceuticalDoseTime
• PostLabelingDelay
• ReceiveGain
• ReconFilterSize
• RepetitionTimePreparation
• SpectrometerFrequency
• VascularCrushingVENC

Would be good to grep for any numeric comparisons for each of these to see if we should wrap them in min/max. At least some EchoTime ones already check for type(EchoTime), so we don't need to rewrite those.

[tsalo]

I just searched for each of those in the rules/checks/ folder and caught one EchoTime check, but that's it.

[effigies]

xref bids-standard/bids-validator#284

[effigies]

@tsalo is this ready for review?

[tsalo]

It is.