Skip to content

fix: Fix TOTAL_ACQUIRED_VOLUMES_NOT_CONSISTENT #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
effigies merged 1 commit into from
Oct 27, 2025
Merged

fix: Fix TOTAL_ACQUIRED_VOLUMES_NOT_CONSISTENT #2236

effigies merged 1 commit into from
Oct 27, 2025

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Oct 27, 2025

Closes #1975.

Changes proposed:

  • Compare TotalAcquiredPairs against both the number of control volumes and the number of label volumes in the aslcontext.tsv file. Only do this if the number of control volumes is greater than 0, in case the ASL scan just contains deltam or cbf volumes.

@tsalo tsalo requested a review from erdalkaraca as a code owner October 27, 2025 16:00
@tsalo tsalo added bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release. labels Oct 27, 2025
@tsalo tsalo changed the title Fix TOTAL_ACQUIRED_VOLUMES_NOT_CONSISTENT fix: Fix TOTAL_ACQUIRED_VOLUMES_NOT_CONSISTENT Oct 27, 2025
effigies
effigies approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this!

@effigies effigies merged commit 2592b29 into bids-standard:maint/1.10.1 Oct 27, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effigies effigies effigies approved these changes

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

Assignees

No one assigned

Labels

bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsalo @effigies