Skip to content

Conversation

@effigies
Copy link
Collaborator

Adding type checking in bids-standard/python-validator#46, we found that some bidsschematools modules we were using were under-annotated.

This adds annotations for the main schema API and the utilities module.

Two bugs were caught by mypy:

  • bst.utils.get_bundled_schema_path called a non-existent function to get the schema path
  • A few functions would not handle non-Path path-likes well.

@effigies effigies added schema-code Updates or changes to the code used to parse, filter, and render the schema. exclude-from-changelog This item will not feature in the automatically generated changelog labels Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.58%. Comparing base (953e550) to head (1ecb936).

Files with missing lines Patch % Lines
tools/schemacode/src/bidsschematools/schema.py 92.00% 2 Missing ⚠️
.../schemacode/src/bidsschematools/types/namespace.py 96.77% 1 Missing ⚠️
tools/schemacode/src/bidsschematools/utils.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           maint/1.10.1    #2264      +/-   ##
================================================
- Coverage         82.70%   82.58%   -0.12%     
================================================
  Files                20       20              
  Lines              1659     1665       +6     
================================================
+ Hits               1372     1375       +3     
- Misses              287      290       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies effigies merged commit dd40ae7 into bids-standard:maint/1.10.1 Nov 18, 2025
19 of 20 checks passed
@effigies effigies deleted the bst/types branch November 18, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant