Skip to content

Conversation

@bclenet
Copy link
Contributor

@bclenet bclenet commented Nov 18, 2025

Closes #2260

Nothing in the specification prevents from using JSON's null as value for metadata fields.
Although it is not rendered properly e.g. in metadata tables.

This PR modifies the get_link function in bids-specification/tools/schemacode/src/bidsschematools/render/utils.py to allow for this kind of rendering (provide a link for the null type):

Key name Requirement Level Data type Description
Command REQUIRED string or null Command used to run the tool. Set to null to describe that the activity was performed manually.

Note

For this to work, src/schema/objects/metadata.yaml must be filled like this:

Command:
  ...
 anyOf:
   type: string
   type: "null"

@bclenet bclenet requested a review from erdalkaraca as a code owner November 18, 2025 10:20
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.83%. Comparing base (373da35) to head (6c01795).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2265   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files          20       20           
  Lines        1672     1672           
=======================================
  Hits         1385     1385           
  Misses        287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies effigies merged commit 886aac1 into bids-standard:master Nov 18, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allowing JSON null as metadata content

2 participants