-
Notifications
You must be signed in to change notification settings - Fork 190
Replace atlas-<label>_description.json with atlases.tsv pattern and also add templates.tsv and cohorts.tsv
#2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bep038
Are you sure you want to change the base?
Conversation
c1098d7 to
bf7ece5
Compare
oesteban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only caveat is now updating the examples accordingly, but overall, I can't see any issues. If TSVs for the atlas metadata are annoying or insufficiently readable, it can be addressed later, as opposed to adding the _description.json file, which is not idempotent.
One thing we did not address in this BEP038 (nor any other BEP) is to allow multiline strings in metadata. Templates and atlases really would need that (at minimum, a way of having their own README and LICENSE files). I'm curious about that in general.
| cohort-1 Ages 0-2 months | ||
| cohort-2 Ages 3-5 months | ||
| cohort-3 Ages 6-11 months | ||
| cohort-4 Ages 1-2 years | ||
| cohort-5 Ages 3-6 years | ||
| cohort-6 Ages 7-18 years |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone can remind me whether we have sub- in the participants.tsv file or it must be removed? If it is not allowed:
| cohort-1 Ages 0-2 months | |
| cohort-2 Ages 3-5 months | |
| cohort-3 Ages 6-11 months | |
| cohort-4 Ages 1-2 years | |
| cohort-5 Ages 3-6 years | |
| cohort-6 Ages 7-18 years | |
| 1 Ages 0-2 months | |
| 2 Ages 3-5 months | |
| 3 Ages 6-11 months | |
| 4 Ages 1-2 years | |
| 5 Ages 3-6 years | |
| 6 Ages 7-18 years |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see
for detailed response, but yes -- all our "{entity}_id", to become those "id" unique across entities, are including entity name in them, so we have sub-{label}, ses-{label} and so on.
src/derivatives/atlas.md
Outdated
| } | ||
| ```tsv | ||
| atlas_id name license description authors species sample_size references_and_links | ||
| atlas-Diedrichsen2009 A probabilistic MR atlas of the human cerebellum LICENSE file Probabilistic atlas of the human cerebellum ["Jörn Diedrichsen", "Joshua H Balsters", "Jonathan Flavell", "Emma Cussans", "Narender Ramnani"] human 20 ["https://doi.org/10.1016/j.neuroimage.2009.01.045"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the github repo is dropped (out of curiosity, doesn't bother me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn AI, thank you the sharp human eye! will fix now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that both records point to github suit... will make sure having it all over
good points, in particular for READMEs. If anything, I would have said to create |
bf7ece5 to
058de33
Compare
side topic -- I tend to use https://www.visidata.org/ @TheChymera once introduced me to **a lot ** and I love it. For that end, it is nice to include a column with paths, since then you could either open directory viewer if points to a folder or just open that text file (with That visidata tool is a godsend for BIDS users in console -- we should really promote it more! ;) |
…adata Introduce templates.tsv and cohorts.tsv files consistent with existing BIDS entity-specific TSV files (participants.tsv, sessions.tsv). - templates.tsv: placed at derivative dataset root, describes tpl-<label> entities - cohorts.tsv: placed within tpl-<label>/ directory, describes cohort-<label> entities This enables consistent documentation of template and cohort entities in derivative datasets. Part of BEP038 atlas metadata improvements. Schema changes: - Add template_id and cohort_id columns to columns.yaml - Add templates and cohorts suffixes to suffixes.yaml - Add Templates and Cohorts rules to common_derivatives.yaml - Add templates and cohorts file rules to tables.yaml - Update atlas.md with templates.tsv and cohorts.tsv documentation Related to: - #2285 - #2283 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
058de33 to
58db0c6
Compare
Replace atlas-<label>_description.json with atlases.tsv for atlas metadata, consistent with existing entity-specific TSV files (participants.tsv, sessions.tsv). Key changes: - atlases.tsv: placed at derivative dataset root or tpl-<label>/ directory - Metadata fields converted to snake_case column names - Array fields (authors, curators, funding, references_and_links) use JSON encoding Schema changes: - Add atlas_id and all atlas-specific columns to columns.yaml - Add atlases suffix to suffixes.yaml - Add Atlases rule to common_derivatives.yaml - Add atlases file rule to tables.yaml - Remove old atlas_description association, context, and metadata rules - Delete atlas.yaml check and file rules Documentation: - Update atlas.md with atlases.tsv section and updated examples - Add JSON-encoded array note - Replace all atlas-<label>_description.json references with atlases.tsv Closes: #2285 Related to: #2283 Related to: #1714 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
58db0c6 to
688a0be
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bep038 #2286 +/- ##
=======================================
Coverage 82.81% 82.81%
=======================================
Files 22 22
Lines 1693 1693
=======================================
Hits 1402 1402
Misses 291 291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a follow-up to PR #1714 (BEP038: Templates and atlases) to make atlas metadata approach consistent with existing BIDS conventions for entity-specific TSV files (like participants.tsv, sessions.tsv, descriptions.tsv, etc).
It was edited to be split into 2 commits, first one is submitted independently for a dedicated, and less radical discussion:
Changes of the 2nd commit here:
The atlases.tsv includes columns derived from the original JSON fields:
Array fields (authors, curators, funding, references_and_links) use JSON-encoded strings in TSV cells.
Schema changes:
This addresses the inconsistency noted in:
via already prevalent in BIDS
[{leading entities}_]{entity_plural}.{tsv,json}file(s) #2283: Proposal to formalize {entities_plural}.tsv pattern