-
Notifications
You must be signed in to change notification settings - Fork 21
fix: use .bids-validator-config.json by default if available. #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rwblair
wants to merge
2
commits into
main
Choose a base branch
from
fix/use_default_config_file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
changelog.d/20251218_163750_rosswilsonblair_use_default_config_file.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <!-- | ||
| A new scriv changelog fragment. | ||
|
|
||
| Uncomment the section that is right (remove the HTML comment wrapper). | ||
| For top level release notes, leave all the headers commented out. | ||
| --> | ||
|
|
||
| <!-- | ||
| ### Added | ||
|
|
||
| - A bullet item for the Added category. | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Changed | ||
|
|
||
| - A bullet item for the Changed category. | ||
|
|
||
| --> | ||
| ### Fixed | ||
|
|
||
| - CLI and web validator now default to loading '.bids-validator-config.json'. Validator only attempts this if no other config file was passed in. | ||
|
|
||
| <!-- | ||
| ### Deprecated | ||
|
|
||
| - A bullet item for the Deprecated category. | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Removed | ||
|
|
||
| - A bullet item for the Removed category. | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Security | ||
|
|
||
| - A bullet item for the Security category. | ||
|
|
||
| --> | ||
| <!-- | ||
| ### Infrastructure | ||
|
|
||
| - A bullet item for the Infrastructure category. | ||
|
|
||
| --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||||||||||||||||||||||||||||||
| import React, { useState } from "react" | ||||||||||||||||||||||||||||||||||
| import "./App.css" | ||||||||||||||||||||||||||||||||||
| import { directoryOpen } from "https://esm.sh/[email protected]" | ||||||||||||||||||||||||||||||||||
| import { directoryOpen, fileOpen } from "https://esm.sh/[email protected]" | ||||||||||||||||||||||||||||||||||
| import confetti from 'https://cdn.jsdelivr.net/npm/[email protected]/dist/confetti.module.mjs'; | ||||||||||||||||||||||||||||||||||
| import { fileListToTree, validate, getVersion } from "../dist/validator/main.js" | ||||||||||||||||||||||||||||||||||
| import type { ValidationResult } from "../../src/types/validation-result.ts" | ||||||||||||||||||||||||||||||||||
|
|
@@ -50,11 +50,19 @@ function App() { | |||||||||||||||||||||||||||||||||
| const [validation, setValidation] = useState<ValidationResult>() | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| async function validateDir() { | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| const dirHandle = await directoryOpen({ | ||||||||||||||||||||||||||||||||||
| recursive: true, | ||||||||||||||||||||||||||||||||||
| }) | ||||||||||||||||||||||||||||||||||
| let config = {} | ||||||||||||||||||||||||||||||||||
| const configFile = dirHandle.find(file => file.name ==='.bids-validator-config.json') | ||||||||||||||||||||||||||||||||||
| if (configFile) { | ||||||||||||||||||||||||||||||||||
| config = configFile.text().then(text => JSON.parse(text)).catch((err) => { | ||||||||||||||||||||||||||||||||||
| alert(`Failed to load ".bids-validator-config.json". \n\nUsing empty configuration object:\n\n${err}`) | ||||||||||||||||||||||||||||||||||
| }) | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
| const fileTree = await fileListToTree(dirHandle) | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+57
to
64
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly:
Suggested change
|
||||||||||||||||||||||||||||||||||
| setValidation(await validate(fileTree, {})) | ||||||||||||||||||||||||||||||||||
| setValidation(await validate(fileTree, config)) | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| const [version, setVersion] = useState<string>() | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we did what we do for
.bidsignoreand pull it out of thetree? We don't need a filesystem hit to check if it's there.We could also use our JSON loader and create an issue. Probably better not to crash...