Skip to content

Conversation

@bendhouseart
Copy link
Contributor

A nested/derivatives bids dataset returns a 0 exit code even if it's evaluated as invalid, this PR sets the exit code to non-zero in that case.

@bendhouseart bendhouseart linked an issue Jan 16, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.00%. Comparing base (f102699) to head (c6bc5dc).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   86.99%   87.00%   +0.01%     
==========================================
  Files          51       51              
  Lines        3883     3887       +4     
  Branches      622      624       +2     
==========================================
+ Hits         3378     3382       +4     
  Misses        495      495              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies
Copy link
Contributor

effigies commented Jan 16, 2026

What about a simple boolean function to find the first error and stop?

Here's a quick function I haven't tested:

export function detectErrors(result: ValidationResult): boolean {
  return result.issues.get({ severity: 'error' }).length > 0 ||
    Object.values(result.derivativesSummary ?? {}).some((res) => detectErrors(res))
}

@bendhouseart
Copy link
Contributor Author

What about a simple boolean function to find the first error and stop?

Here's a quick function I haven't tested:

export function detectErrors(result: ValidationResult): boolean {
  return result.issues.get({ severity: 'error' }).length > 0 ||
    Object.values(result.derivativesSummary ?? {}).some((res) => detectErrors(res))
}

I like where your head's at.

@bendhouseart
Copy link
Contributor Author

ohh boo, now my coverage went down.

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small cleanups

@effigies effigies merged commit e89717b into main Jan 20, 2026
29 checks passed
@effigies effigies deleted the fix/339-bug-update-exit-code-if-recursed-directory-contains-errors branch January 20, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Update Exit Code if Recursed Directory Contains Errors

3 participants