Skip to content

Conversation

@effigies
Copy link
Collaborator

@effigies effigies commented Dec 5, 2024

Since we now build distributions in the Python test workflow, might as well change that to build-test-deploy.

This pushes to test.pypi.org on any push to a branch or tag, and to pypi.org on tags. We don't push on PRs.

@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (36468b3) to head (d06176a).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
+ Coverage   89.43%   89.44%   +0.01%     
==========================================
  Files         130      130              
  Lines       14232    14232              
  Branches     1672     1672              
==========================================
+ Hits        12728    12730       +2     
+ Misses       1106     1104       -2     
  Partials      398      398              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

effigies commented Dec 5, 2024

I'm going to go ahead and merge for the sake of cutting a release. This has no impact on code, and should just fix the broken publication in #1104.

Happy to revert or follow-up with a fixing PR if there are any post-merge reviews.

@effigies effigies merged commit 3150bdf into master Dec 5, 2024
41 checks passed
@effigies effigies deleted the test-pypi-uploads branch December 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants