fix: Render modal in core container element with low priority#74
Merged
antobinary merged 1 commit intobigbluebutton:v0.0.xfrom Sep 4, 2025
Merged
Conversation
|
Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance! |
antobinary
approved these changes
Sep 4, 2025
Member
antobinary
left a comment
antobinary
left a comment
There was a problem hiding this comment.
Tested and it worked well! Thank you!
This was referenced Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the modal be rendered inside the core modal container with low priority so that we can control its stacking order. Giving it low priority will hide it when both audio and video dialogs are open. This also fix an issue where the client get stuck at the pick-random-user modal when the audio dialog is open as well.
Without this fix:
Screencast.from.2025-09-04.10-40-19.webm
With this fix:
Screencast.from.2025-09-04.10-33-39.webm
Closes Issue(s)
Closes none but it's closely related to bigbluebutton/bigbluebutton#23699.