fix: Previously picked user wrongfully notified in next random selections #75
Merged
antobinary merged 2 commits intobigbluebutton:v0.0.xfrom Sep 12, 2025
Merged
Conversation
… ping when they are not selected (context: they were selected previously).
JoVictorNunes
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes a problem described ahead:
Suppose we have a meeting with a moderator (M), and 3 viewers (A, B and C):
This error does not occur everytime, but is sort of frequent;
More
Most of the notification/ping flow was refactored in this PR to be, supposedly, cleaner, more readable and less complex. In order words, it would be good to test other scenarios as well to see if everything keeps working, such as not ping again when reloading the page, not ping multiple times, and so on...