feat: add ip address, user agent, referer and session token if available in the UserJoined event#68
Merged
prlanzarin merged 2 commits intobigbluebutton:developfrom Oct 24, 2025
Conversation
…-joined) The `ip-address` and `user-agent` fields of `user-joined` have two issues: - Incorrect naming: they use `_` instead of `-` as separators; this is not consistent with other attributes - Incorrect parsing: BBB events use `userAgent` and `ipAddress` and webhooks is parsing that incorrectly (i.e.: attributes are never sent) Fix parsing of the above attributes so that they're always sent in `user-joined` when available. Additionally, use `-` as separators for the sake of consistency.
Add the `session-token` attribute to `user-joined` event when available. The payload is an array of strings (session tokens). Here, it's most likely going to be a 1-sized array for the foreseeable future since only the first "join" event for an user is handled (i.e.: no multi-session handling). Keeping it an array should make things future-proof, though, for when multi-session scenarios are handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.