fix(shopping-lists): B2B-3845 Warning about invalid props being passed to html components #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icatalina
commented
Oct 28, 2025
| alignItems, | ||
| textAlignLocation, | ||
| }: FlexItemProps) => ({ | ||
| const ignoreDollarProps = (prop: string): boolean => isPropValid(prop) && !prop.startsWith('$'); |
Contributor
Author
There was a problem hiding this comment.
Ignoring $ props is the pattern that StyledComponents follows by default.
|
|
||
| it('should keep checkbox selection even after the product Qty update', async () => { | ||
| vitest.mocked(useParams).mockReturnValue({ id: '272989' }); | ||
| const spy = vi.spyOn(console, 'error').mockImplementation(() => {}); |
Contributor
Author
There was a problem hiding this comment.
these spies where there to silence these issues, no longer required.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
apps/storefront/src/pages/ShoppingListDetails/components/ReAddToCart.tsx
Outdated
Show resolved
Hide resolved
…d to html components Avoid passing invalid props through styled components directly to HTML components, doing so will trigger a WARNING.
icatalina
force-pushed
the
icatalina/B2B-3845/fix-invalid-props
branch
2 times, most recently
from
f7243eb to
6d96574
Compare
icatalina
commented
Oct 28, 2025
| await waitForElementToBeRemoved(() => screen.queryByText(/loading/i)); | ||
|
|
||
| const rowOfLovelyBoots = screen.getByRole('row', { name: /Lovely boots/ }); | ||
| within(rowOfLovelyBoots).getByRole('checkbox').click(); |
Contributor
Author
There was a problem hiding this comment.
This and the .blur() underneath are throwing a "Not wrapped in an act" warning, replacing for userEvent.click and userEvent.tab which correctly wrap things in an act.
icatalina
force-pushed
the
icatalina/B2B-3845/fix-invalid-props
branch
from
6d96574 to
f7243eb
Compare
bc-victor
approved these changes
Oct 31, 2025
bc-victor
requested changes
Oct 31, 2025
Contributor
bc-victor
left a comment
bc-victor
left a comment
There was a problem hiding this comment.
seems like tests are still failing even after rerunning, also one very minor comment
bc-victor
reviewed
Oct 31, 2025
| describe('Add to quote', () => { | ||
| it('add shopping list to draft quote', async () => { | ||
| vitest.mocked(useParams).mockReturnValue({ id: '272989' }); | ||
| // const spy = vi.spyOn(console, 'error').mockImplementation(() => {}); |
Contributor
Author
There was a problem hiding this comment.
oh, def. sorry...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: B2B-3845
What/Why?
Fix warning about invalid props being passed to html components.
Avoid passing invalid props through styled components directly to HTML components, doing so will trigger a WARNING.
We do that using a filter for
@emotion/styledRollout/Rollback
Revert
Testing
Before:
After:
These warnings show up in the console in the browser and in some tests sometimes.