fix(common): B2B-3799 updated translations based on component and usage #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If we rename or remove the existing keys, clients might see them in English instead of their local language. Waiting for reply from @bc-sylvialin on the translation updating process (Ref) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: B2B-3799
What/Why?
Translations in the buyer-portal are currently being loaded on a per-page basis. Unfortunately, some generic components like Quick Add and Quick Search are used across multiple pages, which causes the translations to reload in the browser and display text in English instead of the translated values.
To address this, I’m moving all common translations (used in shared components or HOCs) to global. This ensures the global translations are loaded initially and prevents missing key issues.
Rollout/Rollback
Revert
Testing
Tested in local
Previous PR
Previous and reverted this as yet to get clarity on promoting translation changes