test(common): FE-432 Avoid using import * from for tests
#636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pattern is not great, vitest offers a nicer way of mocking by using `vi.mock` and replacing only the desired methods from a module. Use `vitest-when` instead of logic where possible.
bc-micah
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: FE-432
What/Why?
Avoid using
import * fromfor testsThis pattern is not great, vitest offers a nicer way of mocking by using
vi.mockand replacing only the desired methods from a module.Use
vitest-wheninstead of logic where possible.Rollout/Rollback
Revert
Testing
These changes only affect tests, if tests pass we are good.