refactor(common): B2B-3967 Fix global types, use regular imports #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icatalina
commented
Nov 14, 2025
| type B3RequestType = typeof B3Request; | ||
| export default B3Request; | ||
|
|
||
| export type { B3RequestType }; |
Contributor
Author
There was a problem hiding this comment.
expose the type to avoid importing the real thing...
| setOpenPage: SetOpenPage; | ||
| } | ||
|
|
||
| export interface FormattedQuoteItem |
Contributor
Author
There was a problem hiding this comment.
These were accidentally deleted when knip was introduced. TSC/knip doesn't consider import('@something').SomeType as used.
They are straight copies from the old types.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
icatalina
commented
Nov 14, 2025
| | 'wordpress' | ||
| | 'custom'; | ||
| declare global { | ||
| /** @deprecated Please avoid using this interface */ |
Contributor
Author
There was a problem hiding this comment.
Added a deprecation warning to these.
Use regular imports so the types in `src/index.d.ts` are checked by the TS compiler. The previous imports were not being checked.
icatalina
force-pushed
the
icatalina/B2B-3967/fix-types-src-index-d-ts
branch
from
e22e040 to
8e93b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: B2B-3967
What/Why?
Fix global types, use regular imports
Use regular imports so the types in
src/index.d.tsare checked by the TS compiler. The previous imports were not being checked.Rollout/Rollback
Revert
Testing
These are only type changes, TS should be able to check.