Skip to content

Conversation

@jordanarldt
Copy link
Contributor

re-merge #2676

@jordanarldt jordanarldt requested a review from a team as a code owner November 14, 2025 22:58
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: 0d0c75f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
catalyst-b2b Ready Ready Preview Comment Nov 14, 2025 10:58pm
catalyst-canary Ready Ready Preview Comment Nov 14, 2025 10:58pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
catalyst Ignored Ignored Nov 14, 2025 10:58pm

Comment on lines 179 to 189
paginationInfo={streamablePaginationInfo}
previousLabel={t('previous')}
productId={productId}
reviews={streamableReviews}
reviewsLabel={t('title')}
streamableImages={streamableImages}
streamableProduct={streamableProductName}
streamableUser={streamableUser}
/>
<Stream fallback={null} value={streamableReviewsData}>
{(product) =>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing translation keys for the review form in French and German will cause broken or empty labels for non-English users.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

Users accessing the site in French or German will see the review form with missing or broken labels. The form labels will either display untranslated key strings (e.g., Form.button), display empty strings, or default fallback values. This will make the new review submission feature unusable for all non-English users.

💡 Suggested Fix

Update fr.json, de.json, and all other supported language translation files with the complete Product.Reviews.Form section and its required keys.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: core/app/[locale]/(default)/product/[slug]/_components/reviews.tsx#L154-L189

Potential issue: Users accessing the site in French or German will see the review form
with missing or broken labels. The form labels will either display untranslated key
strings (e.g., `Form.button`), display empty strings, or default fallback values. This
will make the new review submission feature unusable for all non-English users.

Did we get this right? 👍 / 👎 to inform future reviews.

Reference_id: 2700275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants