-
Notifications
You must be signed in to change notification settings - Fork 337
feat(reviews): add reviews form enabling shoppers to submit reviews #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0d0c75f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| paginationInfo={streamablePaginationInfo} | ||
| previousLabel={t('previous')} | ||
| productId={productId} | ||
| reviews={streamableReviews} | ||
| reviewsLabel={t('title')} | ||
| streamableImages={streamableImages} | ||
| streamableProduct={streamableProductName} | ||
| streamableUser={streamableUser} | ||
| /> | ||
| <Stream fallback={null} value={streamableReviewsData}> | ||
| {(product) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing translation keys for the review form in French and German will cause broken or empty labels for non-English users.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
Users accessing the site in French or German will see the review form with missing or broken labels. The form labels will either display untranslated key strings (e.g., Form.button), display empty strings, or default fallback values. This will make the new review submission feature unusable for all non-English users.
💡 Suggested Fix
Update fr.json, de.json, and all other supported language translation files with the complete Product.Reviews.Form section and its required keys.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: core/app/[locale]/(default)/product/[slug]/_components/reviews.tsx#L154-L189
Potential issue: Users accessing the site in French or German will see the review form
with missing or broken labels. The form labels will either display untranslated key
strings (e.g., `Form.button`), display empty strings, or default fallback values. This
will make the new review submission feature unusable for all non-English users.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2700275
re-merge #2676