fix(storefront): Add missing nonces to all script tags #2539
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I had initially assumed that the nonce-enforcing CSP policy would be applied for all pages, site-wide. However, after testing it, it looks the CSP header is only set on the checkout page. Still, I suppose it doesn't hurt to have the nonce handlebars there just in case nonces are enforced site-wide in the future. |
Contributor
|
I have done the same. The nonce is blank on other pages, and this does not seem to cause any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add missing
nonce="{{nonce}}"nonces to all script tags.Adds to nonces to following files:
templates/pages/account/orders/invoice.htmltemplates/pages/order-confirmation.htmltemplates/components/products/schema.htmltemplates/pages/subscribed.htmlRequirements
Tickets / Documentation
n/a
Screenshots (if appropriate)
n/a