fix(storefront): Add validationDictionary on search page for price range filter error messages #2553
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
bc-yevhenii-buliuk
force-pushed
the
master
branch
from
2b67e3b to
35388a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
On the search page, errors for the price range faceted filter are not displayed. This can be demonstrated on the Cornerstone demo store:
https://www.loom.com/share/17f6a4dfb4064c55948067615b5048e0
It seems the existing error messages are no longer available from
this.contextinsearch.js.To add the missing error messages, I copied the same pattern from
category.jsandbrand.js.Price range filter errors are properly displayed after the patch:
https://www.loom.com/share/4312353e373540f19103af917361da39
Requirements
Tickets / Documentation
n/a
Screenshots (if appropriate)
See above.