fix(storefront): Fix the keyboard navigation on the swatch options #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkanive
requested review from
a team,
bc-alexsaiannyi,
bc-yevhenii-buliuk,
parthshahp and
rtalvarez
bc-alexsaiannyi
approved these changes
Nov 7, 2025
rtalvarez
approved these changes
Nov 7, 2025
parthshahp
approved these changes
Nov 7, 2025
bc-yevhenii-buliuk
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the broken keyboard navigation on the swatch options.
Additional Details
Fixed the issue. The problem was using .get() instead of .eq().
Why this works:
.get(index) returns a DOM element, which doesn't have .trigger()
.eq(index) returns a jQuery object, which has .trigger()
Requirements
Tickets / Documentation
Screenshots (if appropriate)
SwatchOptionsFix.mov