Skip to content

Add interface library to btwxt #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add interface library to btwxt #29

wants to merge 1 commit into from

Conversation

galanCA
Copy link
Contributor

@galanCA galanCA commented Feb 23, 2023 •
edited
Loading

Description

The goal was to replace the use of CMAKE global variable for the use of interface library. This way btwxt will follow its users options.

Changes

  • Replace the contents of compiler-flag.cmake for btwxt interface library

Test

  • Ran against the CI and locally
  • It created new warnings in the test folder that will need to be clean in the following PR when adding the Werror/WX options.

@galanCA galanCA self-assigned this Feb 23, 2023
@galanCA galanCA added the enhancement New feature or request label Feb 23, 2023
@galanCA galanCA requested a review from nealkruis February 23, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealkruis nealkruis Awaiting requested review from nealkruis

At least 1 approving review is required to merge this pull request.

Assignees

@galanCA galanCA

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@galanCA