Additional 232 enhancements #98
Conversation
lattice/schema.py
Outdated
|
|
||
|
|
||
| # Module functions | ||
| def unname_group(expression: RegularExpressionPattern) -> str: |
There was a problem hiding this comment.
Not a great function name, but short.
There was a problem hiding this comment.
...or maybe this should be a member function of RegularExpressionPattern called normalize, cleaned, remove_groups?
There was a problem hiding this comment.
I can make it a static or class method, then we can make it a member if/when the "base class" is implemented.
| if this < other: | ||
| dependency_graph.add_edge(this, other) | ||
| dependency_graph.remove_nodes_from(list(networkx.isolates(dependency_graph))) | ||
| # dependency_graph.remove_nodes_from(list(networkx.isolates(dependency_graph))) |
There was a problem hiding this comment.
Not sure why I was removing unconnected nodes; this was causing the Courier declaration to go missing!
| entry += f"{self._indent}\t{e},\n" | ||
| entry += f"{self._indent}\tUNKNOWN\n{self._indent}{self._closure}" | ||
| if "UNKNOWN" not in self._enumerants: | ||
| entry += f"{self._indent}\tUNKNOWN\n" |
There was a problem hiding this comment.
ClimateInformation::DataSourceType already has an UNKNOWN enumerant in the schema. We've been adding one in all the other enums just for the cpp code. So, now we check first.
There was a problem hiding this comment.
hmmm...do we remember why? This might be worth looking into more later. We can make an issue for now.
There was a problem hiding this comment.
My answer is usually, "Chip".
| ) | ||
| # else: | ||
| # raise Exception(f"Unrecognized Object Type, \"{object_type}\" in {self.file_path}") | ||
| for group in self.data_groups.values(): |
There was a problem hiding this comment.
Separated the extraction of elements into its own loop, in order to have all DataGroup objects available when any element is populated. This allows for an element's type to find its defining DataGroup and see if custom attributes should be applied based on that DataGroup's parents and/or templates.
2 participants
String: Object Type: "Data Type"