Remove redundant script tags #3358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems modal-uikit.md and tabs-javascript.md also have the same issue |
|
Removing the redundant hyperscript tag from modal-uikit.md seems to actually fix duplicate confirm modals followed by console errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The custom model example page has script tags for htmx and hyperscript in both the head and the body. Remove the redundant tags from the body.
Additionally removed extra hyperscript script tags from the UIKit example page and the JavaScript tabs example page. For the former this actually fixes a problem with its behavior.
Testing
I checked the examples still worked when running locally using Zola.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded