Skip to content

Conversation

MichaelWest22
Copy link
Collaborator

@MichaelWest22 MichaelWest22 commented Jul 8, 2025

Description

This is a possible rollback of the fix we put in to handle modified click triggers on form elements preventing default behaviour. It has caused a couple of regressions when links and buttons have elements contained inside them so we may want to consider rolling back this change instead of fixing and retaining this fix in place.

Created this PR so we can compare it with the other PR #3368 and decide which one is the best way forward to resolve the issue. We can close the other PR as we only need one of these merged to resolve the issue.

There is one additional sub bug I found in the last fix up that this will roll back and i've disabled the regression test for this one
a htmx enabled button clicked inside a link will prevent the link from navigating on click which is a edge case that was not handled before where a htmx enabled button clicked inside a link would fire the link full page navigation but this is very edge case.

Corresponding issue:
#3366

Testing

Rolled back tests but retained some of the regression tests added. Also left a couple of disabled tests for the fixes this will roll back.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant