implement reportValidity for reporting proper form validation errors behind config flag #3372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for reportValidity instead of just using checkValidity like it currently does. Because this could possible alter existing applications that don't expect their htmx activated forms to report invalid inputs and update the focus to the first invalid input currently in htmx i've put it behind a new config item. This is default browser behaviour so all users should ideally have this config turned on but having it has a config will prevent any change to existing applications while allowing users than want this the option to turn it on.
Also this change also allows disabling the report validity if you use preventDefault in the htmx:validation:failed event.
Also had to ensure that reportValidity only fires on the first invalid input so it focuses the right item.
This could replace PR #3215
Corresponding issue:
#2372
Testing
Added tests to ensure it focuses on the first input as expected with reportvalidity
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded