Issue 110 #171
Open
Issue 110 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more checking to make sure the object has valid "schedule" property before trying to use it. (Alerts don't have a schedule, but services do. They both use this code.)
Added comments per Asma's review.
- Add iOS to config.xml - Shorten app name on home screen to "BTC" - Clean up Cordova's config.xml file - Add iOS simulator and device actions to Node's package.json - Add iOS icons - Rearrange icon folder
…iOS white screen.
… won't run a local server.
Polyfill Object.assign() for older Androids.
Set minimum versions for Android and iOS.
Added iOS support
…ppy: - Change bundle ID to org.adventurecycling.bicycletouringcompanion - Change version number to 1.0 - Update cordova-plugin-camera to 2.3.0 so it supports the following fixes - Add CAMERA_USAGE_DESCRIPTION which adds a privacy descriptor now required on iOS 10 - Add PHOTOLIBRARY_USAGE_DESCRIPTION which adds a privacy descriptor now required on iOS 10 Also while I'm at it: - Fix the app name in the description - Change the author from last year's team to Adventure Cycling Association #26
Update the following things in config.xml to make the iTunes Store happy:
…ultiple taps to register a button click. I'm not actually sure that updating the dependencies was needed, but it seems like a good thing to do anyway. I think this actually fixed the problem: - Replace "onClick"s with "onTouchTap"s [This seems to work much more consistently with React. Some were already onTouchTap.] - I intentionally didn't replace the onClicks in pointMap.js. They broke when I did and seem to be working as is. I also did this: - Update React - Update Material UI - Update some other dependencies - Wrap whole app in MuiThemeProvider (needed for Material UI update) - Update svg icon imports (needed for Material UI update) - Add namespace to our Drawer class as Material UI renamed their LeftNav to Drawer #3
Removed the user name from the form.
Allow track page to scroll
Fix the issue where WebKit based browsers (Safari) sometimes needed multiple taps to register a button click.
Point btc-models to the "built" branch.
Bumped version number to 1.0.0 to match Cordova (but with an extra .0 to match NPM convention). #40
…s*/ to make the linter happy. #43
…hich ones are updated between reloads. Also, fix up some error checking and messages (including making "Replication error" actually readable). #30
This property wasn't doing anything but freaking out WebKit. Chrome and Safari both scroll properly when the card is too tall without specifying this. #2
Now the user is informed that they must be logged in to publish a point.
Added OpenCycleMap to point-map.js
Bump iOS deployment target to 9.0
Don't resize the point icon to the height of the header.
Update Readme with how to deploy for web
Display "Hours not available" if a service has no associated hours.
Changed the urls from http:// to https://
still not fully functional
still not fully functional
# Conflicts: # src/js/app.js # src/js/containers/reset-password-page.js
Issue 22 - Forget password workflow fix
Comment out the publish delete button and instructions referencing it.
Update model references for separate point and comment DBs.
make ios-deploy an optional dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the ios-deploy to an optional dependency so that it does not fail during npm install on Windows environments.