Refactor bitwise flag operations to use setFlag and getFlag helpers #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all manual bitwise flag operations on the
ffield insrc/crank.tsto use dedicated helper functions, making the code more readable and less error-prone.Changes Made
Added Helper Functions
setFlag(obj, flag, value = true)- Sets or clears a flag based on the value parametergetFlag(obj, flag)- Tests whether a flag is set, returning a booleanReplaced Manual Bitwise Operations
ctx.f |= FLAG→setFlag(ctx, FLAG)ctx.f &= ~FLAG→setFlag(ctx, FLAG, false)ctx.f & FLAG→getFlag(ctx, FLAG)Before vs After Examples
Benefits
Coverage
All flag operations on both
ContextImplandRetainerobjects have been converted, covering all flag constants:HasCommitted,IsCopied(Retainer flags)IsUpdating,IsSyncExecuting,IsInForOfLoop,IsInForAwaitOfLoop,NeedsToYield,PropsAvailable,IsErrored,IsUnmounted,IsSyncGen,IsAsyncGen,IsScheduling,IsSchedulingRefresh,IsRefreshing(Context flags)Verification
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.