-
Notifications
You must be signed in to change notification settings - Fork 79
Set Default Text Color in Playground #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brainkim
merged 17 commits into
main
from
claude/fix-default-text-color-011CUSyNPitHsoRREdZusrVH
Nov 13, 2025
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5e8a235
Fix default text color in playground examples for dark mode
claude 1464807
Apply color-scheme-light class to html element for proper CSS variabl…
claude 2aa8d05
Move color detection to head and set CSS variables as inline styles
claude 3f46b05
Use direct color values with !important to override external CSS
claude b942955
Remove !important rules to allow inline style overrides
claude 4e3c84a
Set CSS variables via JavaScript to prevent external CSS override
claude 78b5c7a
Reorder CSS to ensure color inheritance works properly
claude c84eb1e
Remove hard-coded black color from animated-letters example
claude 925acf5
Extract color scheme logic to shared utilities module
claude a42b8ad
Replace document.write with server-rendered iframe route
claude a8df64a
Fix MathML example colors for dark mode compatibility
claude 5ad41f0
Fix JSX syntax error in playground-preview view
claude aeea5d0
Fix props passed to Root in playground-preview view
claude cde8a29
Remove Root component from playground-preview - return minimal HTML
claude ffc0f68
Use Raw component to output HTML instead of returning plain string
claude 10ded5b
Revert to document.write approach - remove broken iframe route
claude ef94ff6
lint
brainkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -263,6 +263,8 @@ link.href = "https://unpkg.com/[email protected]/index.css"; | |
| // remove default stylesheet for playground | ||
| document.head.querySelector("link").remove(); | ||
| document.head.appendChild(link); | ||
| await new Promise((resolve) => link.addEventListener("load", () => resolve(), {once: true})); | ||
| await new Promise((resolve) => | ||
| link.addEventListener("load", () => resolve(), {once: true}), | ||
| ); | ||
|
|
||
| renderer.render(<App />, document.body); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
getColorSchemeScript()utility could be a component instead.