Fix URL property comparison for src and href attributes #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DOM property for src and href returns the resolved absolute URL, while the prop value may be a relative URL. This caused unnecessary DOM updates on every render when using relative URLs like "/path". Now we resolve the prop value using new URL(value, element.baseURI) before comparing to the DOM value, maintaining the "DOM as source of truth" philosophy while correctly handling URL normalization. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
brainkim1
force-pushed
the
fix-url-prop-comparison
branch
from
98c5431 to
180e315
Compare
Member
|
Thankee Claude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
srcandhrefattributeshttp://localhost/path), while the prop value may be relative (/path)new URL(value, element.baseURI)before comparing, maintaining the "DOM as source of truth" philosophyThis completes the fix from #181 - the original fix compared
element.src !== valueto avoid unnecessary updates, but didn't account for URL resolution causingelement.srcto return an absolute URL while the prop is relative.Test plan
srcon iframehrefon anchor🤖 Generated with Claude Code