Update wallet endpoints #397
Conversation
|
if this pull request helped you, I'll be pleased to give me your feedback. |
|
Using the code I get an error when I don't have any deposits in the result. I get the following result from binance: What can I change to prevent casting to |
| @@ -265,13 +266,14 @@ | |||
| * | |||
| * Enable Withdrawals option has to be active in the API settings. | |||
| * | |||
| * @param asset asset symbol to withdraw | |||
| * @param coin asset symbol to withdraw | |||
| /** | ||
| * Fetch account deposit history. | ||
| * | ||
| * @return deposit history, containing a list of deposits |
| * | ||
| * @return withdraw history, containing a list of withdrawals | ||
| */ | ||
| WithdrawHistory getWithdrawHistory(String coin, int status, Long startTime, Long endTime, |
There was a problem hiding this comment.
I mean comments are somehow missing (new param descriptions)
|
@PanderBoy18 pushed new commits, I hope the bug is fixed |
|
Yesss!!!! This fixed the bug. Great work! |
|
Great! Works for me too! Thanks! |
|
|
||
| @Override | ||
| public void getDepositHistory(String coin, BinanceApiCallback<List<Deposit>> callback) { | ||
| binanceApiService.getDepositHistory(coin, 0, null, null, 0, 1000, |
There was a problem hiding this comment.
The second parameter uses 0 (status) which will result in getting only those deposits, which status is 0 = pending. One should use null instead to get all deposits. For that you should update BinanceApiService interface and use Integer for status field in order to provide null value.
Another way of defaulting would by setting status to 1. This way you will get successful deposits defaultly.
| public void getWithdrawHistory(String asset, BinanceApiCallback<WithdrawHistory> callback) { | ||
| binanceApiService.getWithdrawHistory(asset, BinanceApiConstants.DEFAULT_RECEIVING_WINDOW, System.currentTimeMillis()) | ||
| public void getWithdrawHistory(String coin, BinanceApiCallback<List<Withdraw>> callback) { | ||
| binanceApiService.getWithdrawHistory(coin, 0, null, null, 0, 1000, |
There was a problem hiding this comment.
Same thing as with deposit history. Additionally the new withdrawOrderId is missing. Would be nice to have this in the branch. https://binance-docs.github.io/apidocs/spot/en/#withdraw-history-supporting-network-user_data
|
I continued on this because I ran into the issue of having |
…oints Rezazadeh93 update wallet endpoints
|
Is anyone maintaining this repository? It seems that old pull requests are never merged. |
See #421 |
Updated WAPI endpoints to SAPI endpoints
Added all arguments that are supported by binance to these methods: