feat: allow and require {{ stdlib("c") }} in recipes #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
May 1, 2025
| ``requirements: build:`` section. | ||
| """ | ||
|
|
||
| def check_deps(self, deps): |
Member
There was a problem hiding this comment.
Do we need a check for having stdlib but no compiler?
Contributor
Author
There was a problem hiding this comment.
Good question. It doesn't seem like conda-forge has that check. Although maybe someone might get confused and think they could use it in place of a compiler.
bgruening
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JINJA_VARSto prevent theversion_constraints_missing_whitespacelint error{{ stdlib("c") }}to bioconductor-skeletonSee bioconda/bioconda-recipes#51185
From what I can tell, the
JINJA_VARSpart is used to allow for converting the recipe from string to yaml (which would reject the jinja vars as syntax errors) for various actions by bioconda-utils (such as linting) and not used in the actual build by conda-build. A thorough second look might be a good idea.