-
Notifications
You must be signed in to change notification settings - Fork 134
feat: Simplify unify containers, but with artifacts [WIP] #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
daler
wants to merge
19
commits into
simplify-unify-containers
from
simplify-unify-containers-artifacts
Closed
feat: Simplify unify containers, but with artifacts [WIP] #1046
daler
wants to merge
19
commits into
simplify-unify-containers
from
simplify-unify-containers-artifacts
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8476e18 to
4716da3
Compare
1b04f59 to
2fc00f0
Compare
Member
Author
|
Notes so far:
|
04030d8 to
49b1b7c
Compare
8294e6c to
279a0b7
Compare
9b5fa62 to
99507f7
Compare
Member
Author
|
In good shape; closing in favor of the cleaned-up #1049. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#959 uses ghcr.io as a cache mechanism. However, images stored there are not straightforward to clean up. Artifacts, on the other hand, expire after 90 days. This PR is an experiment to see if it will simplify things further to use artifacts rather than ghcr.io.