Optionally build only the latest version of a recipe. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
May 4, 2017
|
|
||
| logger.info('blacklist: %s', ', '.join(sorted(blacklist))) | ||
|
|
||
| get_recipes = utils.get_recipes |
Contributor
Author
There was a problem hiding this comment.
It is handled in the if below.
Member
There was a problem hiding this comment.
I mean this could be in an else, belonging to the if below.
if latest_only:
get_recipes = utils.get_latest_recipes
else:
get_recipes = utils.get_recipes
Contributor
Author
There was a problem hiding this comment.
Yes, that is right. I did it this way because I thought it better reflects that there is a default case, and a special case (and possibly more in the future).
Member
|
@johanneskoester - What is the status of this? Is it still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.