[FIX] Catch errors during learning in learner widgets #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.32% (diff: 100%)@@ master #1949 diff @@
==========================================
Files 86 86
Lines 9119 9119
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8146 8146
Misses 973 973
Partials 0 0
|
astaric
approved these changes
Jan 25, 2017
astaric
added a commit
that referenced
this pull request
Feb 3, 2017
[FIX] Catch errors during learning in learner widgets (cherry picked from commit af3cb70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The base widget for learners did not intercept errors occurring during fitting.
Description of changes
Errors are now caught and a basic message that something went wrong is displayed. Widgets can provide more specific error messages when possible.
Some widgets tested
self.valid_datato verify that fitting succeeded. This did not really work. Although it now would, the tests are replaced to check whetherself.modelis notNone. This is more appropriate since the data may be valid when the model is not.A minor fix needed for tests:
Modelchecked whether thedomainparameter is given by checkingif domain. This is wrong sinceDomaindoes not have__bool__, so__len__is used instead, and soDomain([])is treated asFalse.Includes