Skip to content

[FIX] data/io.py Metadata file not saved anymore when it is empty #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astaric merged 1 commit into from
Feb 9, 2017
Merged

[FIX] data/io.py Metadata file not saved anymore when it is empty #2002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Orange/data/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def write(cls, filename, data):

@classmethod
def write_table_metadata(cls, filename, data):
if isinstance(filename, str) and hasattr(data, 'attributes'):
if isinstance(filename, str) and getattr(data, 'attributes', None):
if all(isinstance(key, str) and isinstance(value, str)
for key, value in data.attributes.items()):
with open(filename + '.metadata', 'w') as f:
Expand Down
20 changes: 20 additions & 0 deletions Orange/tests/test_tab_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,3 +206,23 @@ def test_data_name(self):
table2 = TabReader(table1.__file__).read()
self.assertEqual(table1.name, 'iris')
self.assertEqual(table2.name, 'iris')

def test_metadata(self):
tempdir = tempfile.mkdtemp()
table = Table("titanic")
table.attributes = OrderedDict()
table.attributes["a"] = "aa"
table.attributes["b"] = "bb"
fname = path.join(tempdir, "out.tab")
TabReader.write_table_metadata(fname, table)
self.assertTrue(path.isfile(fname + ".metadata"))
shutil.rmtree(tempdir)

def test_no_metadata(self):
tempdir = tempfile.mkdtemp()
table = Table("titanic")
table.attributes = OrderedDict()
fname = path.join(tempdir, "out.tab")
TabReader.write_table_metadata(fname, table)
self.assertFalse(path.isfile(fname + ".metadata"))
shutil.rmtree(tempdir)