[ENH] Distances: Offload work to a separate thread #4046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4046 +/- ##
==========================================
+ Coverage 86.2% 86.22% +0.02%
==========================================
Files 396 396
Lines 70437 70609 +172
==========================================
+ Hits 60718 60885 +167
- Misses 9719 9724 +5 |
janezd
requested changes
Oct 11, 2019
Contributor
janezd
left a comment
janezd
left a comment
There was a problem hiding this comment.
This slows down the widget significantly. Iteration over rows must remain in Cython code, with callback every now and then.
Callbacks shouldn't happen in every row (because it involves calling Python code). Perhaps call it 100 times, that is, every n_rows / 100 rows.
VesnaT
changed the title
VesnaT
force-pushed
the
concurrent_distances
branch
from
6da8b7e to
5fd4e26
Compare
VesnaT
changed the title
VesnaT
force-pushed
the
concurrent_distances
branch
2 times, most recently
from
160d5da to
e7bd4cb
Compare
janezd
reviewed
Nov 29, 2019
VesnaT
force-pushed
the
concurrent_distances
branch
2 times, most recently
from
369fb40 to
702ada0
Compare
VesnaT
changed the title
VesnaT
force-pushed
the
concurrent_distances
branch
from
702ada0 to
cb0431a
Compare
VesnaT
changed the title
Contributor
|
Please rebase to current master, which fixes the failed tests caused by changes in sklearn 0.22. |
VesnaT
force-pushed
the
concurrent_distances
branch
from
cb0431a to
f2071ec
Compare
VesnaT
changed the title
VesnaT
force-pushed
the
concurrent_distances
branch
from
f2071ec to
93e8266
Compare
VesnaT
changed the title
VesnaT
force-pushed
the
concurrent_distances
branch
from
c910e48 to
c10ce62
Compare
janezd
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Partially fixes #3810.
Description of changes
Distance calculation now runs in a separate thread.
It is only possible to interrupt the Euclidean distance by now. Other distances will be adopted once the changes are approved.
Includes