[FIX] Distances: Fix restoring the cosine distance #4311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4311 +/- ##
======================================
Coverage 86.7% 86.7%
======================================
Files 396 396
Lines 71618 71618
======================================
Hits 62095 62095
Misses 9523 9523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When saving a Distance widget with cosine distance it was restored as Mahalonobis. In https://github.com/biolab/orange3/pull/4280/files settings_version was not increased.
Description of changes
Increasing the settings version.
Includes